Re: [PATCH] test: Better handling of stdout and stderr

Subject: Re: [PATCH] test: Better handling of stdout and stderr

Date: Tue, 16 Nov 2010 11:32:59 -0800

To: Michal Sojka, notmuch@notmuchmail.org

Cc:

From: Carl Worth

On Sun, 14 Nov 2010 22:52:20 +0100, Michal Sojka <sojkam1@fel.cvut.cz> wrote:
> I'm sending the fixes to the test suite as responses to this mail.

Excellent fixes, Michal. Thanks so much!

I've pushed these out now, with one tiny followup to remove the
hard-coded:

	test_expect_equal '' ''

which looked really odd to me.

I didn't see any other problems in my review of these patches.

Thanks again,

-Carl

-- 
carl.d.worth@intel.com

• Previous message (by thread): Re: [PATCH 3/5] test: Break on test script (or other) error

Thread:

• Michal Sojka—[PATCH] test: Better handling of stdout and stderr [inbox, unread]
  • Carl Worth—Re: [PATCH] test: Better handling of stdout and stderr [inbox, signed, unread]
    • Carl Worth—Re: [PATCH] test: Better handling of stdout and stderr [inbox, signed, unread]
      • Michal Sojka—Re: [PATCH] test: Better handling of stdout and stderr [inbox, unread]
      • Michal Sojka—Re: [PATCH] test: Better handling of stdout and stderr [inbox, unread]
        • Michal Sojka—[PATCH 1/5] test: Better handling of stdout and stderr [inbox, unread]
        • Michal Sojka—[PATCH 2/5] test: Add trailing newline to error messages [inbox, unread]
        • Michal Sojka—[PATCH 3/5] test: Break on test script (or other) error [inbox, unread]
          • Carl Worth—Re: [PATCH 3/5] test: Break on test script (or other) error [inbox, signed, unread]
            • Michal Sojka—Re: [PATCH 3/5] test: Break on test script (or other) error [inbox, unread]
        • Michal Sojka—[PATCH 4/5] test: Detect unfinished subsets [inbox, unread]
        • Michal Sojka—[PATCH 5/5] test: Fix bugs detected thanks to the previous commit [inbox, unread]
        • Carl Worth—Re: [PATCH] test: Better handling of stdout and stderr [inbox, signed, unread]