Re: [PATCH] Do not attept to output part raw if part is not GMimePart.

Subject: Re: [PATCH] Do not attept to output part raw if part is not GMimePart.

Date: Mon, 27 Jun 2011 10:07:44 -0700

To: Carl Worth, Notmuch Mail

Cc:

From: Jameson Graef Rollins

On Thu, 23 Jun 2011 16:33:18 -0700, Carl Worth <cworth@cworth.org> wrote:
> I'd like to investigate this case a little bit to help answer the
> question of whether "notmuch should have done anything in this case".

Hi, Carl.  You can see this error if you try to output raw a multipart/*
or message/rfc822 part, ie:

servo:~ 0$ notmuch show --part=1 --format=raw id:"87wrgccedd.fsf@yoom.home.cworth.org" >/dev/null

(process:29838): GLib-GObject-WARNING **: invalid cast from `GMimeMultipartSigned' to `GMimePart'

(process:29838): gmime-CRITICAL **: g_mime_part_get_content_object: assertion `GMIME_IS_PART (mime_part)' failed
servo:~ 0$ 

Gmime seems to be successfully casting the part into GMimePart and then
outputting the content, but it does produce the warning on stderr.

jamie.

• Previous message (by thread): Re: [PATCH] Do not attept to output part raw if part is not GMimePart.

Thread:

• Jameson Graef Rollins—[PATCH] Do not attept to output part raw if part is not GMimePart. [inbox, notmuch::pushed, unread]
  • Jameson Graef Rollins—[PATCH] Do not attept to output part raw if part is not GMimePart. [inbox, notmuch::pushed, unread]
    • Carl Worth—Re: [PATCH] Do not attept to output part raw if part is not GMimePart. [inbox, notmuch::pushed, signed, unread]
      • Jameson Graef Rollins—Re: [PATCH] Do not attept to output part raw if part is not GMimePart. [inbox, notmuch::pushed, signed, unread]
        • Austin Clements—Re: [PATCH] Do not attept to output part raw if part is not GMimePart. [inbox, notmuch::pushed, unread]
          • Daniel Kahn Gillmor—Re: [PATCH] Do not attept to output part raw if part is not GMimePart. [inbox, notmuch::pushed, signed, unread]
          • Jameson Graef Rollins—Re: [PATCH] Do not attept to output part raw if part is not GMimePart. [inbox, notmuch::pushed, signed, unread]
            • Austin Clements—Re: [PATCH] Do not attept to output part raw if part is not GMimePart. [inbox, notmuch::pushed, unread]
              • Daniel Kahn Gillmor—interaction between --format=raw and multipart handling [was: Re: Do not attept to output part raw if part is not GMimePart.] [inbox, notmuch::pushed, signed, unread]
                • Austin Clements—Re: interaction between --format=raw and multipart handling [was: Re: Do not attept to output part raw if part is not GMimePart.] [inbox, notmuch::pushed, unread]
    • Jameson Graef Rollins—Re: [PATCH] Do not attept to output part raw if part is not GMimePart. [inbox, notmuch::pushed, signed, unread]
      • Dmitry Kurochkin—Re: [PATCH] Do not attept to output part raw if part is not GMimePart. [inbox, notmuch::pushed, unread]
      • Jameson Graef Rollins—Re: [PATCH] Do not attept to output part raw if part is not GMimePart. [inbox, notmuch::pushed, signed, unread]
        • David Bremner—Re: [PATCH] Do not attept to output part raw if part is not GMimePart. [inbox, notmuch::pushed, unread]
          • Jameson Graef Rollins—Re: [PATCH] Do not attept to output part raw if part is not GMimePart. [inbox, unread]