Re: [PATCH 1/2] test: add more maildir flag syncing related tests to insert

Subject: Re: [PATCH 1/2] test: add more maildir flag syncing related tests to insert

Date: Tue, 03 Sep 2013 06:26:43 -0300

To: Jani Nikula, notmuch@notmuchmail.org

Cc:

From: David Bremner

Jani Nikula <jani@nikula.org> writes:
>  
> +test_begin_subtest "Insert message with default tags stays in new/"
> +gen_insert_msg
> +notmuch insert < "$gen_msg_filename"
> +output=$(notmuch search --output=files id:$gen_msg_id)
> +dirname=$(dirname "$output")
> +test_expect_equal "$dirname" "$MAIL_DIR/new"

I'm not sure if this is a bug or a feature, but this enforces a
constraint on the default tags that notmuch ships enabled. Is that what
we want, or would it be better to set unread explicitely here?

d

• Previous message (by thread): Re: [PATCH 1/3] test: Adding non-maildir tags does not move message from new to cur

Thread:

• Michal Sojka—[PATCH 0/3] Adding non-maildir tags does not move message from new to cur [inbox, unread]
  • Michal Sojka—[PATCH 1/3] test: Adding non-maildir tags does not move message from new to cur [inbox, notmuch::patch, notmuch::pushed, unread]
    • David Bremner—Re: [PATCH 1/3] test: Adding non-maildir tags does not move message from new to cur [inbox, unread]
  • Michal Sojka—[PATCH 2/3] test: Add some missing maildir synchronization tests [inbox, notmuch::patch, notmuch::pushed, unread]
  • Michal Sojka—[PATCH 3/3] tags_to_maildir_flags: Don't rename if no flags change [inbox, notmuch::patch, notmuch::pushed, unread]
    • david@tethera.net—[PATCH] test: update insert tests for new maildir synchronization rules [inbox, notmuch::patch, notmuch::pushed, unread]
      • Jani Nikula—[PATCH 1/2] test: add more maildir flag syncing related tests to insert [inbox, notmuch::patch, notmuch::pushed, unread]
        • Jani Nikula—[PATCH 2/2] test: improve insert test reliability by checking message-id instead of count [inbox, notmuch::patch, notmuch::pushed, unread]
        • David Bremner—Re: [PATCH 1/2] test: add more maildir flag syncing related tests to insert [inbox, unread]
          • Jani Nikula—Re: [PATCH 1/2] test: add more maildir flag syncing related tests to insert [inbox, unread]
      • Jani Nikula—Re: [PATCH] test: update insert tests for new maildir synchronization rules [inbox, unread]
  • Jani Nikula—Re: [PATCH 0/3] Adding non-maildir tags does not move message from new to cur [inbox, unread]