Re: [PATCH] emacs: show: let the user override the mime-type of an attachment

Subject: Re: [PATCH] emacs: show: let the user override the mime-type of an attachment

Date: Sat, 01 Aug 2015 22:47:08 +0200

To: Mark Walters, notmuch@notmuchmail.org

Cc:

From: David Bremner


Mark Walters <markwalters1009@gmail.com> writes:

> +(defun notmuch-show-internal-mm-display-part (handle)

It's very much a quibble, but I don't understand the naming scheme
here. Is internal meant to denote an privateish function? If so the
convention of using -- (notmuch-show--mm-display-part, I guess) seems
more common in the code base. Or does internal/external refer to viewers
here?

Otherwise, it looks good. The only thing that I really missed was
completion on mime types. But that makes sense as a seperate patch, even
if it is easy, and I have no idea how easy it is.

d





Thread: