Re: [PATCH v5 0/7] Add refresh all buffers functionality

Subject: Re: [PATCH v5 0/7] Add refresh all buffers functionality

Date: Mon, 10 Oct 2016 16:27:13 +0300

To: Mark Walters, notmuch@notmuchmail.org

Cc:

From: Ioan-Adrian Ratiu


On Sun, 09 Oct 2016, Mark Walters <markwalters1009@gmail.com> wrote:
> This is a simplified version of the series at
> id:20161008210139.25322-1-adi@adirat.com
>
> The main change is that it makes all the refresh functions refresh the
> buffer without forcing the buffer to be displayed. 
>
> In tree and show mode this was already the case; in search mode it is
> a change but since the refresh function has to be called in the buffer
> it is likely to already be displayed. In hello mode it a genuine
> change, but notmuch-hello-update is a trivial wrapped of notmuch-hello
> so anyone who wants to force display can just call notmuch-hello.
>
> Once this change is made Ionel's changes become very clean.

LGTM. I had a few minutes to apply and test this series and all my
use-cases work perfectly. Thank you for helping with this.

>
> Best wishes
>
> Mark
>
>
> Ioan-Adrian Ratiu (4):
>   emacs: notmuch-search: add no-display functionality
>   emacs: notmuch-search-refresh-view: reuse buffer
>   emacs: notmuch-show: refresh all windows displaying buffer
>   emacs: notmuch-lib: add refresh all buffers function
>
> Mark Walters (3):
>   emacs: tree: make refresh use generic binding
>   emacs: make the refresh functions more consistent
>   emacs: hello: stop update from forcing the buffer to be displayed
>
>  emacs/notmuch-hello.el |  7 ++++---
>  emacs/notmuch-lib.el   | 23 ++++++++++++++++++-----
>  emacs/notmuch-show.el  | 19 +++++++++++++------
>  emacs/notmuch-tree.el  |  1 -
>  emacs/notmuch.el       | 16 +++++++++++-----
>  5 files changed, 46 insertions(+), 20 deletions(-)
>
> -- 
> 2.1.4

Thread: