Tomi Ollila <tomi.ollila@iki.fi> writes:

> On Mon, Apr 18 2022, michaeljgruber wrote:
>
>> From: Michael J Gruber <git@grubix.eu>
>>
>> 7228fe68 ("configure: restructure gmime cert validity checker code",
>> 2022-04-09) restructured generated C code to repurpose it later on. This
>> put usage of `validity` within an `#if`, resulting in an "unused
>> warning" if that `#if` is not executed.
>>
>> Put the variable declariation inside the same if branch and, thus,  quel
>> the warning.
>
> IMO the code could be changed to be even more RAIIy (even so that is not
> common style there), also IMO removing warning is good enough reason to
> deviate from that style (just in one place) so LGTM from me :D
>
> Tomi

applied to master.

d
_______________________________________________
notmuch mailing list -- notmuch@notmuchmail.org
To unsubscribe send an email to notmuch-leave@notmuchmail.org