Re: [notmuch] [PATCH] Simplify "unread" tag handling in emacs UI.

Subject: Re: [notmuch] [PATCH] Simplify "unread" tag handling in emacs UI.

Date: Wed, 17 Feb 2010 14:33:11 +0100

To: Jameson Rollins, Notmuch Mail list

Cc:

From: Sebastian Spaeth


On Tue, 19 Jan 2010 17:54:16 -0500, Jameson Rollins <jrollins@finestructure.net> wrote:
> This patch is intended to greatly simplify the handling of the
> "unread" tag in the emacs UI.  This patch adds a new function
> 'notmuch-show-mark-read', that removes the "unread" tag in
> notmuch-show-mode.  This function is then executed as a
> notmuch-show-hook, and by notmuch-show-next-message.  All of the
> functions that explicitly marked messages as unread are removed or
> renamed.

Hi Jameson,

I've been using this for quite some time now and I am pretty happy with
it. However, there is a problem with this approach as this renders the
function notmuch-show-next-unread-message useless. 

This proceeds to the next message, using
notmuch-show-next-message, which your patch marks automatically as read.

It then checks the unread status in order to decide whether to proceed
to the next again. So with your patch notmuch-show-next-unread-message
will skip through all messages in a thread thinking they are all read
(and actually marking all as read).

Sebastian

Thread: