Re: [PATCH] emacs: Tab completion for notmuch-search and notmuch-search-filter

Subject: Re: [PATCH] emacs: Tab completion for notmuch-search and notmuch-search-filter

Date: Tue, 09 Aug 2011 19:31:44 +0200

To: Jameson Graef Rollins, Notmuch Mail

Cc:

From: Daniel Schoepe

On Fri, 05 Aug 2011 23:09:23 -0700, Jameson Graef Rollins <jrollins@finestructure.net> wrote:
> Hey, Daniel.  I actually just ran into a little bug with this patch.
> After applying this patch, if I try to scroll/search through my
> mini-buffer history after a search I get the following error:
> 
> previous-history-element: Wrong type argument: symbolp, "tag:signed"
> 
> I get this error no matter what my search terms were.
> 
> Unfortunately I've always found these error messages confusing, so I'm
> not quite sure where it's coming from.  I clearly has something to do
> with how searches are now stored in the mini-buffer history (symbol
> instead of string?).

Turns out, I just used `read-from-minibuffer' incorrectly, here's an
updated version. 

• Previous message (by thread): Re: [PATCH] emacs: Tab completion for notmuch-search and notmuch-search-filter

Thread:

• Daniel Schoepe—[PATCH] emacs: Tab completion for notmuch-search and notmuch-search-filter [inbox, notmuch::feature, notmuch::obsolete, notmuch::patch, unread]
  • Daniel Schoepe—[PATCH] emacs: Tab completion for notmuch-search and notmuch-search-filter [inbox, notmuch::feature, notmuch::obsolete, notmuch::patch, unread]
  • Austin Clements—Re: [PATCH] emacs: Tab completion for notmuch-search and notmuch-search-filter [inbox, notmuch::review, unread]
    • Daniel Schoepe—Re: [PATCH] emacs: Tab completion for notmuch-search and notmuch-search-filter [inbox, notmuch::feature, notmuch::obsolete, notmuch::patch, signed, unread]
      • Daniel Schoepe—Re: [PATCH] emacs: Tab completion for notmuch-search and notmuch-search-filter [inbox, notmuch::feature, notmuch::obsolete, notmuch::patch, signed, unread]
      • Austin Clements—Re: [PATCH] emacs: Tab completion for notmuch-search and notmuch-search-filter [inbox, notmuch::review, unread]
        • Daniel Schoepe—Re: [PATCH] emacs: Tab completion for notmuch-search and notmuch-search-filter [inbox, notmuch::feature, notmuch::obsolete, notmuch::patch, signed, unread]
          • Daniel Schoepe—Re: [PATCH] emacs: Tab completion for notmuch-search and notmuch-search-filter [inbox, notmuch::feature, notmuch::obsolete, notmuch::patch, signed, unread]
            • Daniel Schoepe—Re: [PATCH] emacs: Tab completion for notmuch-search and notmuch-search-filter [inbox, signed, unread]
              • Jameson Graef Rollins—Re: [PATCH] emacs: Tab completion for notmuch-search and notmuch-search-filter [inbox, notmuch::review, signed, unread]
                • Jameson Graef Rollins—[PATCH] emacs: Tab completion for notmuch-search and notmuch-search-filter [inbox, notmuch::feature, notmuch::obsolete, notmuch::patch, unread]
                  • Jameson Graef Rollins—Re: [PATCH] emacs: Tab completion for notmuch-search and notmuch-search-filter [inbox, signed, unread]
                    • Daniel Schoepe—Re: [PATCH] emacs: Tab completion for notmuch-search and notmuch-search-filter [inbox, signed, unread]
                      • Jameson Graef Rollins—Re: [PATCH] emacs: Tab completion for notmuch-search and notmuch-search-filter [inbox, unread]
                    • Daniel Schoepe—[PATCH] emacs: Tab completion for notmuch-search and notmuch-search-filter [inbox, notmuch::feature, notmuch::patch, notmuch::pushed, unread]
                      • David Bremner—Re: [PATCH] emacs: Tab completion for notmuch-search and notmuch-search-filter [inbox, unread]