Re: proposed patches to notmuch-emacs-mua

Subject: Re: proposed patches to notmuch-emacs-mua

Date: Sun, 20 Aug 2017 15:11:12 +0300

To: Joseph Mingrone, notmuch@freelists.org

Cc:

From: Jani Nikula

Please consider using git-send-email to get the thread structure right
in your contribution. See also https://notmuchmail.org/contributing/.

On Sat, 22 Jul 2017, Joseph Mingrone <jrm@ftfl.ca> wrote:
> From e44343e36b5591c3ffbb150c64da4855aa9127f0 Mon Sep 17 00:00:00 2001
> From: Joseph Mingrone <jrm@ftfl.ca>
> Date: Thu, 20 Jul 2017 20:28:06 -0300
> Subject: [PATCH 2/3] Use message-goto-signature to insert file in message body
>
> Users may call, e.g., mml-secure-message-sign to insert MML at the top
> of the message.  By using message-goto-signature to insert file
> contents into the body of the message, the MML remains at the top.

You leave out the details *where* the users would call
mml-secure-message-sign in a way that would conflict with
message-goto-body. Are you referring to a hook that fills in the MML tag
before message-goto-body gets called?

Anyway, you apparently didn't try this with a signature. This change
inserts all the body contents under the "-- " line, which is obviously
unacceptable.

BR,
Jani.

> ---
>  emacs/notmuch-emacs-mua | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/emacs/notmuch-emacs-mua b/emacs/notmuch-emacs-mua
> index 1af2f413..521dd342 100755
> --- a/emacs/notmuch-emacs-mua
> +++ b/emacs/notmuch-emacs-mua
> @@ -95,7 +95,7 @@ while getopts :s:c:b:i:h opt; do
>  	    ELISP="${ELISP} (message-goto-bcc) (insert \"${OPTARG}, \")"
>  	    ;;
>  	--body|i)
> -	    ELISP="${ELISP} (message-goto-body) (insert-file \"${OPTARG}\")"
> +	    ELISP="${ELISP} (message-goto-signature) (insert-file \"${OPTARG}\")"
>  	    ;;
>  	--print)
>  	    PRINT_ONLY=1
> -- 
> 2.13.3

Thread: