Re: [PATCH v2 12/15] cli: reduce indent in keyword argument processing

Subject: Re: [PATCH v2 12/15] cli: reduce indent in keyword argument processing

Date: Sun, 01 Oct 2017 21:33:18 -0300

To: Jani Nikula, notmuch@notmuchmail.org

Cc: Daniel Kahn Gillmor

From: David Bremner

Jani Nikula <jani@nikula.org> writes:

> Reducing indent makes future changes easier. No functional changes.

First 12 patches LGTM.

d
_______________________________________________
notmuch mailing list
notmuch@notmuchmail.org
https://notmuchmail.org/mailman/listinfo/notmuch

• Previous message (by thread): Re: [PATCH v2 12/15] cli: reduce indent in keyword argument processing

Thread:

• Jani Nikula—[PATCH v2 00/15] cli: argument parsing changes [inbox, unread]
  • Jani Nikula—[PATCH v2 01/15] cli: strip trailing "/" from the final maildir path in notmuch insert [inbox, notmuch::patch, notmuch::pushed, unread]
  • Jani Nikula—[PATCH v2 02/15] cli: use designated initializers for opt desc [inbox, notmuch::patch, notmuch::pushed, unread]
  • Jani Nikula—[PATCH v2 03/15] test: add boolean argument to arg-test [inbox, notmuch::patch, notmuch::pushed, unread]
  • Jani Nikula—[PATCH v2 04/15] test: add opt_inherit to arg-test [inbox, notmuch::patch, notmuch::pushed, unread]
  • Jani Nikula—[PATCH v2 05/15] cli: add .present field to opt desc to check if the arg was present [inbox, notmuch::patch, notmuch::pushed, unread]
  • Jani Nikula—[PATCH v2 06/15] test: expand argument parsing tests [inbox, notmuch::patch, notmuch::pushed, unread]
  • Jani Nikula—[PATCH v2 07/15] cli: use the arg parser .present feature to handle show --entire-thread [inbox, notmuch::patch, notmuch::pushed, unread]
  • Jani Nikula—[PATCH v2 08/15] hex-xcode: use notmuch_bool_t for boolean arguments [inbox, notmuch::patch, notmuch::pushed, unread]
  • Jani Nikula—[PATCH v2 09/15] cli: use notmuch_bool_t for boolean argument in show [inbox, notmuch::patch, notmuch::pushed, unread]
  • Jani Nikula—[PATCH v2 10/15] cli: refactor boolean argument processing [inbox, notmuch::patch, notmuch::pushed, unread]
  • Jani Nikula—[PATCH v2 11/15] cli: change while to for in keyword argument processing [inbox, notmuch::patch, notmuch::pushed, unread]
  • Jani Nikula—[PATCH v2 12/15] cli: reduce indent in keyword argument processing [inbox, notmuch::patch, notmuch::pushed, unread]
    • David Bremner—Re: [PATCH v2 12/15] cli: reduce indent in keyword argument processing [inbox, unread]
      • David Bremner—Re: [PATCH v2 12/15] cli: reduce indent in keyword argument processing [inbox, unread]
  • Jani Nikula—[PATCH v2 13/15] cli: add support for --no- prefixed boolean and keyword flag arguments [inbox, notmuch::obsolete, notmuch::patch, unread]
    • William Casarin—Re: [PATCH v2 13/15] cli: add support for --no- prefixed boolean and keyword flag arguments [inbox, unread]
      • Jani Nikula—Re: [PATCH v2 13/15] cli: add support for --no- prefixed boolean and keyword flag arguments [inbox, unread]
  • Jani Nikula—[PATCH v2 14/15] cli: use the negating boolean support for new and insert --no-hooks [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Jani Nikula—[PATCH v2 15/15] test: expand argument parsing sanity checks [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Jani Nikula—[PATCH] cli: allow empty strings for notmuch insert --folder argument [inbox, notmuch::obsolete, notmuch::patch, unread]