On Thu 2020-01-09 22:38:02 -0400, David Bremner wrote:
> Daniel Kahn Gillmor <dkg@fifthhorseman.net> writes:
>
>> On Mon 2019-12-23 17:17:22 -0500, Daniel Kahn Gillmor wrote:
>>> Ship a new debian package for the notmuch2 CFFI-based Python interface
>>> to notmuch.
>>>
>>> Unlike the notmuch python module, the new notmuch2 module is no longer
>>> arch-independent, because it builds and ships a shared object in
>>> addition to the python code.
>
> Do you understand if installed the _capi.abi3.so into /usr/lib/python3.8/...
> is correct? It does seem a bit suspicious to tie it to the specific
> version of python3, and lintian complains.
What lintian complaint do you see? When i built it originally back in
december, there was no lintian complaint.
When i build it today, I see:
W: python3-notmuch2: python-module-in-wrong-location usr/lib/python3.8/dist-packages/notmuch2/ usr/lib/python3/dist-packages/notmuch2/
W: python3-notmuch2: python-module-in-wrong-location usr/lib/python3.8/dist-packages/notmuch2/_capi.abi3.so usr/lib/python3/dist-packages/notmuch2/_capi.abi3.so
in the older package, i see only one copy of the .so, but in the version
built today, i see two copies (i think identical):
0 dkg@alice:~/src/notmuch/notmuch$ dpkg --contents ../python3-notmuch2_0.29.3+109~gef0d513+1_amd64.deb | grep so$
-rw-r--r-- root/root 73616 2019-12-23 17:23 ./usr/lib/python3/dist-packages/notmuch2/_capi.abi3.so
0 dkg@alice:~/src/notmuch/notmuch$ dpkg --contents ../python3-notmuch2_0.29.3+111~g4c95a79+1_amd64.deb | grep so$
-rw-r--r-- root/root 73784 2020-01-10 15:10 ./usr/lib/python3/dist-packages/notmuch2/_capi.abi3.so
-rw-r--r-- root/root 73784 2020-01-10 15:10 ./usr/lib/python3.8/dist-packages/notmuch2/_capi.abi3.so
0 dkg@alice:~/src/notmuch/notmuch$
during the more recent build, i also see this warning from dh_python3:
W: dh_python3 fs:112: Paths differ: debian/python3-notmuch2/usr/lib/python3.8/dist-packages/notmuch2/_capi.abi3.so and debian/python3-notmuch2/usr/lib/python3/dist-packages/notmuch2/_capi.abi3.so
I confess i don't really understand what happened to change this, since
the package should be almost exactly the same source.
comparing the .buildinfo files, i see a few minor version changes that
might be relevant:
- python3 (= 3.7.5-1),
+ python3 (= 3.7.5-3),
- python3-all (= 3.7.5-1),
+ python3-all (= 3.7.5-3),
- python3.7 (= 3.7.5-2),
- python3.7-minimal (= 3.7.5-2),
- python3.8 (= 3.8.0-5),
- python3.8-minimal (= 3.8.0-5),
+ python3.7 (= 3.7.6-1),
+ python3.7-minimal (= 3.7.6-1),
+ python3.8 (= 3.8.1-2),
+ python3.8-minimal (= 3.8.1-2),
- debhelper (= 12.7.2),
+ debhelper (= 12.7.3),
they were both built with dh-python 4.20191017)
but none of these changes ought to warrant shipping an extra copy of the
.so file.
So i'm a little bit confused about what happened here. :/
>> Pinging on this patch as well. If we want the notmuch2 python module to
>> be used, we need to get it in wider distribution. having it installable
>> via "apt install python3-notmuch2" would be a good start.
>
> We'll need an upstream notmuch release including the new bindings for
> this to make a difference. It might make sense to do that soon-ish.
agreed.
--dkg