Re: [PATCH] devel/nmweb: read mail files in binary mode.

Subject: Re: [PATCH] devel/nmweb: read mail files in binary mode.

Date: Mon, 18 Sep 2023 06:22:26 -0300

To: Tomi Ollila, notmuch@notmuchmail.org

Cc:

From: David Bremner


Tomi Ollila <tomi.ollila@iki.fi> writes:

>
> Looks good to me. I've been experiencing "text" mode defaulting to 'ascii'
> (and had to include encoding='utf-8') lately. Another problem one may
> encounter when there are \r chars in the file, text mode may remove those
> (In the same case I had a file using '\r\r' as list content separator,
> and failed until changing open to binary mode)
>
> Tomi
>

thanks for the review. Applied to master and deployed that (again) to
nmbug.notmuchmail.org. Probably I should think of a deployment method
that does not involve git merge :(.


d
_______________________________________________
notmuch mailing list -- notmuch@notmuchmail.org
To unsubscribe send an email to notmuch-leave@notmuchmail.org

Thread: