Re: [PATCH 1/2] Build symbol-test with make instead of hardcoding in symbol-hiding.

Subject: Re: [PATCH 1/2] Build symbol-test with make instead of hardcoding in symbol-hiding.

Date: Sat, 26 Nov 2011 11:12:46 -0800

To: Amadeusz Żołnowski, notmuch@notmuchmail.org

Cc:

From: David Bremner

On Fri, 25 Nov 2011 11:54:51 +0100, Amadeusz Żołnowski <aidecoe@aidecoe.name> wrote:
> If symbol-test is built in symbol-hiding with hardcoded g++ invokation,
> it's not so easy to pass $(srcdir) which is required to find notmuch.h
> when srcdir and builddir are separate directories.
> ---

Sorry to do this to you, but I pushed Dmitry's patch to test/basic
first, so can you please rebase?

thanks

d

• Previous message (by thread): Re: [PATCH] Build symbol-test with make instead of hardcoding in symbol-hiding.

Thread:

• Amadeusz Żołnowski—[PATCH 1/2] Build symbol-test with make instead of hardcoding in symbol-hiding. [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Amadeusz Żołnowski—[PATCH 2/2] Fixed warnings for test/symbol-test.cc. [inbox, notmuch::obsolete, notmuch::patch, unread]
    • David Bremner—Re: [PATCH 2/2] Fixed warnings for test/symbol-test.cc. [inbox, unread]
      • Amadeusz Żołnowski—[PATCH 2/3] Fix warnings for test/symbol-test.cc. [inbox, notmuch::patch, notmuch::pushed, unread]
        • Amadeusz Żołnowski—[PATCH 3/3] Whitespaces cleanup. [inbox, notmuch::patch, notmuch::pushed, unread]
  • David Bremner—Re: [PATCH 1/2] Build symbol-test with make instead of hardcoding in symbol-hiding. [inbox, unread]
    • Amadeusz Żołnowski—Re: [PATCH 1/2] Build symbol-test with make instead of hardcoding in symbol-hiding. [inbox, signed, unread]
  • David Bremner—Re: [PATCH 1/2] Build symbol-test with make instead of hardcoding in symbol-hiding. [inbox, unread]
    • Amadeusz Żołnowski—[PATCH] Build symbol-test with make instead of hardcoding in symbol-hiding. [inbox, unread]
      • Amadeusz Żołnowski—Re: [PATCH] Build symbol-test with make instead of hardcoding in symbol-hiding. [inbox, signed, unread]
        • Amadeusz Żołnowski—[PATCH] Build symbol-test with make instead of hardcoding in symbol-hiding. [inbox, unread]
          • David Bremner—Re: [PATCH] Build symbol-test with make instead of hardcoding in symbol-hiding. [inbox, unread]
          • Dmitry Kurochkin—Re: [PATCH] Build symbol-test with make instead of hardcoding in symbol-hiding. [inbox, unread]