On Mon, 30 Apr 2012, Austin Clements <amdragon@MIT.EDU> wrote: > I haven't really looked at this series yet, but I do have a quick > high-level question. Why use separate customization variables for the > colors in search and show mode? Wouldn't it make more sense to set > the colors just once and use them in both modes? I think that their use is somewhat different since in show mode the colour can be quite high contrast because mostly you only have a few header lines (that may depend how much time you spend in expanded/collapsed views); one example is that in show mode the header line normally has a background colour (I think even without customisation) whereas in search mode that would be weird as every line would have it. > BTW, I like how this clearly distinguishes tags and flags. I wonder > if we could transition to flags for some information that's current > shoe-horned into tags but actually represents immutable information > about a message (attachment, signed, and encrypted or so). Yes some of those could make sense: I hadn't thought about them at all. I think attachment is closer to a genuine tag as I frequently include tag:attachment in my searched but I would guess that searching for signed/encrypted is not as common (but I don't use either so could be wrong) > My one concern is that there's a common tag called "flagged", so this > might be overloading terminology. I hadn't thought of that: I agree but don't have a good suggestion for avoiding it. Best wishes Mark > > Quoth Mark Walters on Apr 29 at 11:48 pm: >> This is a rebased (but otherwise unchanged) version of >> id:"1334431301-27303-1-git-send-email-markwalters1009@gmail.com". >> >> It's probably too late for 0.13 but in case anyone would like to look >> at it this version applies cleanly to master so should be easier to >> test. >> >> The first two patches are basically David Edmondson's patch >> id:"1325006003-27152-1-git-send-email-dme@dme.org". >> >> Best wishes >> >> Mark >> >> >> Mark Walters (3): >> emacs: Move colour line from search to lib >> emacs: Add `notmuch-show-line-faces' and apply it. >> emacs: allow notmuch-show-line-faces to use flags for colouring >> >> emacs/notmuch-lib.el | 18 ++++++++++++++++++ >> emacs/notmuch-show.el | 44 ++++++++++++++++++++++++++++++++++++++++---- >> emacs/notmuch.el | 15 +-------------- >> 3 files changed, 59 insertions(+), 18 deletions(-)