Re: python notmuch2 bindings exclude_tags not added correctly to query

Subject: Re: python notmuch2 bindings exclude_tags not added correctly to query

Date: Fri, 25 Dec 2020 14:36:40 -0400

To: Johannes Larsen, notmuch@notmuchmail.org

Cc:

From: David Bremner

Johannes Larsen <mail@johslarsen.net> writes:

> A typo in Database._create_query loses the exclude_tag names during the
> string to utf-8 conversion.
>
>
> The problem is fixed by this patch applied to current master (ced341e8):
>
> diff --git i/bindings/python-cffi/notmuch2/_database.py w/bindings/python-cffi/notmuch2/_database.py
> index 5ab0f20a..868f4408 100644
> --- i/bindings/python-cffi/notmuch2/_database.py
> +++ w/bindings/python-cffi/notmuch2/_database.py
> @@ -581 +581 @@ class Database(base.NotmuchObject):
> -                    tag = str.encode('utf-8')
> +                    tag = tag.encode('utf-8')
>
> -- 

Thanks for the fix. I've included it in release 0.31.3.

If you could use "git send-email" (or at least "git format-patch") for
future contributions, that would decrease that chance if my bungling
things.

Thanks again,

David
_______________________________________________
notmuch mailing list -- notmuch@notmuchmail.org
To unsubscribe send an email to notmuch-leave@notmuchmail.org

Thread: