Apologies for the lack of subject. Still caffeine deficient this
morning...

David Bremner <david@tethera.net> writes:

> 7) This code makes heavier use of GLib than most notmuch code.  In
> particular there is extensive use of g_auto macros for memory
> management.  These could be replaced with more use of talloc, but that
> would require a few more low level utility routines to be written.

The other thing it makes me think is that GLib is arguably badly
re-inventing C++, so that's something to ponder. I don't know if argues
for just using C++, or for going the extra mile and using talloc.

> 8) Performance has been optimized for the case of few changes to the
> database since last git-push (analogous notmuch restore)

9) I replaced the shelling out to "git var" with interrogating the
notmuch configuration database. The behaviour is slightly different, in
particular GIT_COMMITTER_* environment variables are currently
ignored. Obeying those could be added fairly simply, I think. There are
probably other subtlties to how git constructs GIT_COMMITTER_IDENT; I'm
not sure if those are important.

10) I observed there are still a few relics of the "git-remote-nm" name
in the code.

11) I think this should eventually save and restore configuration
    information and properties like dump / restore do. I don't see any
    conceptual barrier to doing so, just more code.


_______________________________________________
notmuch mailing list -- notmuch@notmuchmail.org
To unsubscribe send an email to notmuch-leave@notmuchmail.org