On Sun, 29 May 2011 02:03:47 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmail.com> wrote: > Also, the patch adds Content-id to text output format of notmuch > show. I don't think I've raised this point before, but I've been tempted to setup a git hook that rejects any commits with a paragraph beginning with the word "also" or the word "additionally". These words are clues to me that the commit is doing multiple independent things and should really be split up. > The patch makes notmuch show always output filename if available, > independent of Content-Disposition. Both JSON and text output > formats are changed. The commit message claims to change both JSON and text output, (and the patch bears that out). But the test suite only gets changes to text output. This suggests to me that the test suite needs an additional test here (for a "Content-Disposition: inline" attachment with a filename). What can I say, I must be feeling soft today, because in spite of both of those issues I've just pushed these two commits, (I did augment the commit message of the second commit to be more than a single line—I know that I've discussed that issue before). Thanks, Dmitry, for the improvements. -Carl -- carl.d.worth@intel.com