Damien Cassou <damien.cassou@gmail.com> writes: > This patch obsoletes > id:1352565719-12397-1-git-send-email-damien.cassou@gmail.com > > [PATCH 1/4] emacs: Add a thread's tags to emacs header-line > [PATCH 2/4] emacs: Make tags in header-line clickable > [PATCH 3/4] emacs: Make tags that appear in `notmuch-show' clickable > [PATCH 4/4] emacs: Add unit-tests for clickable tags in notmuch-show > > This patch makes clickable all tags that appear in notmuch-show > buffers. Each tag is a link to open a new notmuch-search buffer for > this tag. Additionally, the buffer's header-line now shows the > thread's tags (clickable only if the `header-button' library is loaded > or loadable). Looks fine to me. Let me just get the notes from my bikeshed, in case you get asked to roll another version :) - You might want to use #' on lambdas. - It bothers me how similar notmuch-tagger-{body,header}-button-action are. I thought it might be better to unify them by seeing what type the button argument was. Here's my (untested) approach which you might find prettier or uglier. (notmuch-tagger-all-button-get (button attrib) "Utility function to do button-get on different kinds of buttons." (cond ((integer-or-marker-p button) (button-get button attrib)) ((and (featurep 'header-button) (listp button)) (header-button-get button attrib)) (t (error "unknown type of button %s" button)) - The comment for notmuch-tagger-make-body-link reads that it will work "everywhere except in the header-line". Does this mean mode-line, menu bar, or what? How about just "won't work in the header-line"? - In patch 3: +If tags the result of this function is to be used within the I think this should just read "If the result". Ethan