David Bremner <david@tethera.net> writes: > > So if there is no quote, we skip the part after the ':'? I guess I > probably missed something because that doesn't sound like the intended > behaviour. Indeed the following addition to the test shows it works fine in context. So I guess I just don't follow this control flow very well. diff --git a/test/dump-restore b/test/dump-restore index aecc393..f9ae5b3 100755 --- a/test/dump-restore +++ b/test/dump-restore @@ -200,6 +200,8 @@ a # the next non-comment line should report an an empty tag error for # batch tagging, but not for restore + +e -- id:20091117232137.GA7669@griffis1.net +# valid id, but warning about missing message ++e id:missing_message_id EOF cat <<EOF > EXPECTED @@ -211,6 +213,7 @@ Warning: no query string after -- [+c +d --] Warning: hex decoding of tag %zz failed [+%zz -- id:whatever] Warning: cannot parse query: id:" Warning: not an id query: tag:abc +Warning: cannot apply tags to missing message: missing_message_id EOF test_expect_equal_file EXPECTED OUTPUT