Re: [PATCH] lib: Precede all function names in notmuch-private.h with an underscore.

Subject: Re: [PATCH] lib: Precede all function names in notmuch-private.h with an underscore.

Date: Thu, 08 May 2014 21:29:30 +0900

To: Charles Celerier, notmuch@notmuchmail.org

Cc:

From: David Bremner


Charles Celerier <cceleri@cs.stanford.edu> writes:

> An underscore should precede every function name in
> lib/notmuch-private.h. 
 
Is this a reference to notmuch coding style document, or something else?

> This was not true and was noted by the failure of test
> T360-symbol-hiding on Mac OS/X. This patch inserts an underscore
> before each function name in lib/notmuch-private.h where the
> underscore was missing and renames functions appropriately where they
> are used.

I'm not sure I understand the problem this patch is intended to solve.
Is the problem that symbols are being inadvertantly exported? Or the
test is wrong?  

d

Thread: