David Bremner <david@tethera.net> writes:
> + notmuch->exception_reported = TRUE;
> + if (! notmuch->exception_reported) {
> + _notmuch_database_log (notmuch, "Error: A Xapian exception occurred setting metadata: %s\n",
> + error.get_msg().c_str());
> + }
Upon revisiting, this looks pretty silly. According to the commit
message in e2341cb the point of exception_reported is to avoid excess
error reporting when closing/flushing after another error. Since we
don't actually print these error messages anymore, I'm not sure it's
even needed. In any case, this is a bad case of copy-pasta, which I've
fixed in git by removing the if (in both places).