Re: [PATCH 1/3] CLI: add talloc leak report, controlled by an environment variable.

Subject: Re: [PATCH 1/3] CLI: add talloc leak report, controlled by an environment variable.

Date: Thu, 20 Dec 2012 12:58:19 -0400

To: Tomi Ollila, notmuch@notmuchmail.org

Cc:

From: David Bremner


Tomi Ollila <tomi.ollila@iki.fi> writes:

> On Mon, Dec 17 2012, david@tethera.net wrote:
>
>> From: David Bremner <bremner@debian.org>
>>
>> The argument handling in notmuch.c seems due for an overhaul, but
>> until then use an environment variable to specify a location to write
>> the talloc leak report to.  This is only enabled for the (interesting)
>> case where some notmuch subcommand is invoked.
>> ---
>
> I'd still suggest to have similar command-line interface option(s) as
> samba4 use: --leak-report and/or --leak-report-full
>
> (search --leak-r in talloc(3) namual page)
>

Sure sounds fine, when someone (TM) redoes the top level argument
handling. I think it would make sense to ditch the alias handling
completely; both current aliases are deprecated for a long time.

d

Thread: