Re: [PATCH 2/4] test: added --stderr=FILE tests

Subject: Re: [PATCH 2/4] test: added --stderr=FILE tests

Date: Sat, 25 May 2013 14:02:41 +0300

To: Tomi Ollila, notmuch@notmuchmail.org

Cc: tomi.ollila@iki.fi

From: Jani Nikula

On Fri, 24 May 2013, Jani Nikula <jani@nikula.org> wrote:
> On Thu, 23 May 2013, Tomi Ollila <tomi.ollila@iki.fi> wrote:
>> --stderr=FILE tests were added to test/help-test as it is the one
>> doing most global option testing. Also, it was simplest to test
>> this new option using `notmuch help` command.
>> ---
>>
>> In the future this file (help-test) could be renamed and used in
>> more generic "global option" testing
>>
>>  test/help-test | 10 ++++++++++
>>  1 file changed, 10 insertions(+)
>>
>> diff --git a/test/help-test b/test/help-test
>> index f7df725..8b77931 100755
>> --- a/test/help-test
>> +++ b/test/help-test
>> @@ -9,4 +9,14 @@ test_expect_success 'notmuch help' 'notmuch help'
>>  test_expect_success 'notmuch help tag' 'notmuch help tag'
>>  test_expect_success 'notmuch --version' 'notmuch --version'
>>  
>> +test_begin_subtest "notmuch --stderr=stderr help %"
>> +notmuch --stderr=stderr help %
>> +test_expect_equal "$(cat stderr)" "
>> +Sorry, % is not a known command. There's not much I can do to help."
>> +
>> +test_begin_subtest "notmuch --stderr=- help %"
>> +notmuch --stderr=stderr help %
>
> Leftover line from copy-paste?

Apart from this, the whole series LGTM.

BR,
Jani.

Thread: