Re: [PATCH 5/7] emacs: hello: require cl

Subject: Re: [PATCH 5/7] emacs: hello: require cl

Date: Sat, 11 Mar 2017 11:01:39 -0400

To: Mark Walters, notmuch@notmuchmail.org

Cc: Tomi Ollila

From: David Bremner

Mark Walters <markwalters1009@gmail.com> writes:
>  
> -(eval-when-compile (require 'cl))
> +(require 'cl)
>  (require 'widget)
>  (require 'wid-edit) ; For `widget-forward'.
>  
> @@ -1017,3 +1017,7 @@ (defun notmuch-folder ()
>  ;;
>  
>  (provide 'notmuch-hello)
> +
> +;; Local Variables:
> +;; byte-compile-warnings: (not cl-functions)
> +;; End:

I was wondering if we should make any attempt to use cl-lib instead of
cl.el, since the former is more supported in newer emacs (e.g. allowed
for use in core code, I think). On the other hand, maybe it just causes
problems with emacs 23 (which we haven't completely dropped yet)

Thread: