On Thu 2017-11-30 08:01:18 -0400, David Bremner wrote:
> Daniel Kahn Gillmor <dkg@fifthhorseman.net> writes:
>
>> The following patch series should be fairly unobjectionable cleanup of
>> the debian packaging for notmuch.
>>
>> Let me know if you think there are problems with any of it.
>
> Not problems per se, but I would expect several of these things to be
> documented in debian/changelog, including the standards version change.

I was presuming to do one rollup patch to build out the debian/changelog
entry as release time approaches, rather than including changelog
messages in the patches themselves.

That rollup patch should be fairly easy to do with, e.g.:

    gbp dch --new-version=0.26-1 debian/

I prefer this approach because:

 (a) it doesn't confuse changelog messages with patches, and

 (b) it means that we don't end up with heavily-ordered patches, where
     it's more difficult merge some patches from a series than others,
     because each patch to d/changelog depends on the immediately prior
     changeset.

I'd much rather you (or anyone else reviewing) can immediately and
trivially pull the changes you like from the series while leaving the
ones you're less certain about unmerged, for further discussion.

Case in point here, the change to python3-sphinx might be more
problematic than i'd originally expected.  I wouldn't want anyone to
have to rewrite the subsequent trivial patches just to leave that one
behind.

Is there a reason to prefer patching d/changelog in each individual
changeset?

        --dkg
_______________________________________________
notmuch mailing list
notmuch@notmuchmail.org
https://notmuchmail.org/mailman/listinfo/notmuch