Re: [PATCH v2] Name thread based on matching msgs instead of first msg.

Subject: Re: [PATCH v2] Name thread based on matching msgs instead of first msg.

Date: Wed, 21 Apr 2010 15:59:57 -0700

To: Jesse Rosenthal, notmuch@notmuchmail.org

Cc:

From: Carl Worth


On Sat, 17 Apr 2010 13:59:22 -0400, Jesse Rosenthal <jrosenthal@jhu.edu> wrote:
> At the moment all threads are named based on the name of the first message
> in the thread. However, this can cause problems if people either start
> new threads by replying-all (as unfortunately, many out there do) or
> change the subject of their mails to reflect a shift in a thread on a
> list.

Thanks, Jesse. This is a nice new feature.

I've pushed this out now, followed up with several changes:

  * Simplify the assignment of the correct subject
  * Add test cases
  * Fix the feature to actually pass the tests

I know that my simplified version was broken (the tests showed
that). I'm not sure if the original version would have passed the tests
or not. But at least things seem to be working now.

-Carl
part-000.sig (application/pgp-signature)

Thread: