Re: [PATCH 1/2] emacs: Add auto-tagging for replied messages.

Subject: Re: [PATCH 1/2] emacs: Add auto-tagging for replied messages.

Date: Tue, 27 Apr 2010 08:29:03 -0700

To: Jesse Rosenthal, Notmuch developer list

Cc:

From: Carl Worth


On Tue, 27 Apr 2010 09:06:59 -0400, Jesse Rosenthal <jrosenthal@jhu.edu> wrote:
> Add `notmuch-message-mark-replied', a function for automatically tagging
> replied messages with user-defined tags.

A nice, feature. Thanks!

A couple of points on the patch:

> +(defcustom notmuch-message-replied-tags '("replied")
> +  "A set of tags to be added or, if prefaced with a `-', removed. For 
> +example, \(\"replied\" \"-inbox\" \"-todo\"\)"

This documentation string needs to be improved a bit. Look in customize
and see if only the first line appears by default. If so, we don't want
a widowed "For" at the end of the line.

Also, this documentation string doesn't actually give a new user enough
information to learn what this actually does.

Should say something like:

"Tags to be added/removed from messages when sending a reply to that message."

as the first sentence. That tells the user what the feature does and
whether it's interesting. If so, the user can expand the documentation
and subsequent sentences can explain things like '-', etc.

Finally, since this is a new feature it needs to add a new blurb to the
NEWS file.

Thanks,

-Carl
part-000.sig (application/pgp-signature)

Thread: