Re: [PATCH] Save and restore point explicitly in `notmuch-wash-toggle-invisible-action'.

Subject: Re: [PATCH] Save and restore point explicitly in `notmuch-wash-toggle-invisible-action'.

Date: Tue, 24 May 2011 15:57:32 -0700

To: Austin Clements, Dmitry Kurochkin

Cc: notmuch@notmuchmail.org

From: Carl Worth


On Tue, 24 May 2011 18:43:41 -0400, Austin Clements <amdragon@mit.edu> wrote:
> Saving point this way is a bit dangerous, though.  For example, if
> you're near the end of the buffer and shorten the label, attempting to
> restore the point could result in an error (or, a more benign example:
> the cursor could wind up outside the label so pressing RET repeatedly
> won't toggle it).

Without the patch to change save-excursion to an integer, point is
already moving outside the button, (so that repeatedly pressing RET
doesn't toggle).

I'm exploring a proper fix now to get reliable behavior.

-Carl
part-000.sig (application/pgp-signature)

Thread: