Re: [PATCH] notmuch restore --accumulate

Subject: Re: [PATCH] notmuch restore --accumulate

Date: Fri, 09 Sep 2011 11:45:13 +0200

To: Louis Rilling, Jameson Graef Rollins

Cc: notmuch@notmuchmail.org

From: Thomas Schwinge

Hi!

On Fri, 9 Sep 2011 11:06:34 +0200, Louis Rilling <l.rilling@av7.net> wrote:
> On 05/09/11 12:31 -0700, Jameson Graef Rollins wrote:
> > Also, we generally prefer to have modifications to the test suite in
> > separate patches that precede the patches that add the features/fix the
> > bugs.
> > 
> 
> For new features, this does not look like 'git bisect'-safe.

Exactly my thoughts.  I can perhaps see the usefulness (for first
separately committing the testcase) for bugfixes, but why for new
features?

> I would say that
> the testsuite patch should follow the new feature patch, don't you?

I would keep them together; why separate them?


Grüße,
 Thomas

• Previous message (by thread): Re: Updated v3 patches for notmuch restore --accumulate.

Thread:

• Thomas Schwinge—[PATCH] notmuch restore --accumulate [inbox, notmuch::patch, notmuch::pushed, unread]
  • Jameson Graef Rollins—Re: [PATCH] notmuch restore --accumulate [inbox, notmuch::pushed, signed, unread]
    • Louis Rilling—Re: [PATCH] notmuch restore --accumulate [inbox, unread]
      • Thomas Schwinge—Re: [PATCH] notmuch restore --accumulate [inbox, notmuch::pushed, signed, unread]
        • Austin Clements—Re: [PATCH] notmuch restore --accumulate [inbox, notmuch::pushed, unread]
          • Thomas Schwinge—Re: [PATCH] notmuch restore --accumulate [inbox, notmuch::pushed, signed, unread]
            • Austin Clements—Re: [PATCH] notmuch restore --accumulate [inbox, notmuch::pushed, unread]
            • Jameson Graef Rollins—Re: [PATCH] notmuch restore --accumulate [inbox, notmuch::pushed, signed, unread]
              • Thomas Schwinge—[PATCH] patchformatting: Test Suite Enhancements [inbox, notmuch::patch, notmuch::pushed, unread]
  • Thomas Schwinge—[PATCH, v2] notmuch restore --accumulate [inbox, notmuch::patch, notmuch::pushed, unread]
    • Thomas Schwinge—[PATCH, v2] notmuch restore --accumulate [inbox, notmuch::patch, notmuch::pushed, unread]
      • David Bremner—Updated v3 patches for notmuch restore --accumulate. [inbox, notmuch::pushed, unread]
        • David Bremner—[PATCH 1/6] test/test-lib.sh: update comments [inbox, notmuch::patch, notmuch::pushed, unread]
        • David Bremner—[PATCH 2/6] test/dump-restore: expand test suite for dump-restore, make more robust [inbox, notmuch::patch, notmuch::pushed, unread]
        • David Bremner—[PATCH 3/6] test/dump-restore: add tests for restore --accumulate [inbox, notmuch::patch, notmuch::pushed, unread]
        • David Bremner—[PATCH 4/6] notmuch-restore: implement --accumulate option [inbox, notmuch::patch, notmuch::pushed, unread]
        • David Bremner—[PATCH 5/6] test/dump-restore: Fix quoting on grep [inbox, notmuch::patch, notmuch::pushed, unread]
        • David Bremner—[PATCH 6/6] notmuch-restore: check for extra arguments. [inbox, notmuch::patch, notmuch::pushed, unread]
          • David Bremner—[PATCH 1/2] notmuch.1: typo fixes new wording for dump/restore [inbox, notmuch::patch, notmuch::pushed, unread]
            • David Bremner—[PATCH 2/2] docs: Update news, man page, and online help for restore --accumulate [inbox, notmuch::patch, notmuch::pushed, unread]
        • David Bremner—Re: Updated v3 patches for notmuch restore --accumulate. [inbox, notmuch::pushed, signed, unread]
    • David Bremner—Re: [PATCH, v2] notmuch restore --accumulate [inbox, notmuch::pushed, unread]