Re: [PATCH v4 0/4] Allow JSON to use non-entire thread, and use for elide

Subject: Re: [PATCH v4 0/4] Allow JSON to use non-entire thread, and use for elide

Date: Mon, 28 May 2012 00:30:20 +0200

To: Mark Walters, notmuch@notmuchmail.org

Cc:

From: Daniel Schoepe


On Tue, 24.04.2012 11:11, Mark Walters wrote:
> The first three patches implement the client side changes: one to
> allow null messages to be output in Json (without upsetting the
> parsing/structure), one to do the command line parsing for
> --entire-thread=false and one to update the schemata.
>
> The final emacs patch is independent (and the first three make sense
> without it) and uses this new functionality to implement the elide
> option.
>
> I think this addresses all review comments

LGTM (all four patches). I think both version of the command line
parsing patch would be acceptable, but the second one seems cleaner to
me.

Cheers,
Daniel
part-000.sig (application/pgp-signature)

Thread: