Re: [PATCH 5/5] lib: Separate all phrases indexed by _notmuch_message_gen_terms

Subject: Re: [PATCH 5/5] lib: Separate all phrases indexed by _notmuch_message_gen_terms

Date: Wed, 18 Jun 2014 18:11:23 -0300

To: Austin Clements, notmuch@notmuchmail.org

Cc:

From: David Bremner


Austin Clements <amdragon@MIT.EDU> writes:

> This adds a 100 termpos gap between all phrases indexed by
> _notmuch_message_gen_terms.  This fixes a bug where terms from the end
> of one header and the beginning of another header could match together
> in a single phrase and a separate bug where term positions of
> un-prefixed terms overlapped.
>
> This fix only affects newly indexed messages.  Messages that are
> already indexed won't benefit from this fix without re-indexing, but
> the fix won't make things any worse for existing messages.

The series looks OK to me. It took me a little while to understand the
problem with multiple parts was that the term positions currently start
from zero for each part. If you happen to be re-rolling the series for
some other reason, maybe you could be more explicit about that. I
wouldn't bother just for that though.

d

Thread: