Re: [PATCH] emacs: reply: remove wrong sig/enc status buttons

Subject: Re: [PATCH] emacs: reply: remove wrong sig/enc status buttons

Date: Mon, 12 Sep 2016 18:57:17 +0200

To: David Bremner, Mark Walters, notmuch@notmuchmail.org

Cc:

From: Daniel Kahn Gillmor


On Mon 2016-09-12 03:11:44 +0200, David Bremner wrote:
> Mark Walters <markwalters1009@gmail.com> writes:
>
>> This stopps the (usually incorrect) sigstatus and encstatus buttons
>> appearing when replying in emacs, and updates the test suite to match.
>>
>> Overriding the status button functions is a little unusual but much
>> less intrusive than passing an argument all the way down the call
>> chain. It also makes it clear exactly what it does.
>> ---
>>
>> I dont't have any encrypted messages for testing but it seems to work
>> on signed messages (but even that is very lightly tested). 
>
> In replies encrypted messages there is an extra line saying Version:
> 1. This is from the first part part of the multipart encrypted
>
> └┬╴multipart/encrypted 6845 bytes
>  ├─╴application/pgp-encrypted attachment [PGPMIME version identification] 11 bytes
>  └─╴application/octet-stream inline [encrypted.asc] 2708 bytes
>
> I'm not really sure it's useful to display in notmuch-show mode
> either. If not, that would fix it here also. Perhaps Daniel can comment
> on whether it makes sense to just drop it.

Yes, it makes no sense to include the "Version: 1" in the
quoted/attributed text either.  It'd be great to remove that as well.

                  --dkg
signature.asc (application/pgp-signature)

Thread: