Re: [PATCH 6/6] lib: choose oldest message when breaking reference loops

Subject: Re: [PATCH 6/6] lib: choose oldest message when breaking reference loops

Date: Tue, 24 Apr 2018 22:52:23 -0300

To: Tomi Ollila, notmuch@notmuchmail.org

Cc:

From: David Bremner

Tomi Ollila <tomi.ollila@iki.fi> writes:

> Otherwise the series _looks_ good do me. The thing that disturbs me are
> these `strlen (in_reply_to)` contents. Perhaps SomeOne(TM) changes these
> to e.g. in_reply_to[0] in the future...
>

That same file defines and uses an EMPTY_STRING macro. We should
probably be consistent, either use that macro everywehre or
nowhere. Perhaps move it to lib/notmuch-private.h?

d
_______________________________________________
notmuch mailing list
notmuch@notmuchmail.org
https://notmuchmail.org/mailman/listinfo/notmuch

• Previous message (by thread): Re: reference loop fix and tests, v2

Thread:

• David Bremner—reference loop fix and tests, v2 [inbox, unread]
  • David Bremner—[PATCH 1/5] test: two new messages for the 'broken' corpus [inbox, notmuch::obsolete, notmuch::patch, unread]
    • Tomi Ollila—Re: [PATCH 1/5] test: two new messages for the 'broken' corpus [inbox, unread]
      • Daniel Kahn Gillmor—Re: [PATCH 1/5] test: two new messages for the 'broken' corpus [inbox, unread]
  • David Bremner—[PATCH 2/5] test: add known broken test for indexing an In-Reply-To loop. [inbox, notmuch::obsolete, notmuch::patch, unread]
  • David Bremner—[PATCH 3/5] lib: break reference loop by choosing arbitrary top level msg [inbox, notmuch::obsolete, notmuch::patch, unread]
    • Daniel Kahn Gillmor—Re: [PATCH 3/5] lib: break reference loop by choosing arbitrary top level msg [inbox, unread]
  • David Bremner—[PATCH 4/5] test: add second reference loop test [inbox, notmuch::obsolete, notmuch::patch, unread]
  • David Bremner—[PATCH 5/5] NEWS: add item for reference loop fix. [inbox, notmuch::obsolete, notmuch::patch, unread]
    • David Bremner—v3 reference loop fix [inbox, unread]
      • David Bremner—[PATCH 1/6] test: two new messages for the 'broken' corpus [inbox, notmuch::patch, notmuch::pushed, unread]
      • David Bremner—[PATCH 2/6] test: add known broken test for indexing an In-Reply-To loop. [inbox, notmuch::patch, notmuch::pushed, unread]
      • David Bremner—[PATCH 3/6] lib: break reference loop by choosing arbitrary top level msg [inbox, notmuch::patch, notmuch::pushed, unread]
      • David Bremner—[PATCH 4/6] NEWS: add item for reference loop fix. [inbox, notmuch::patch, notmuch::pushed, unread]
      • David Bremner—[PATCH 5/6] test: add known broken test for thread ordering from a loop [inbox, notmuch::patch, notmuch::pushed, unread]
      • David Bremner—[PATCH 6/6] lib: choose oldest message when breaking reference loops [inbox, notmuch::patch, notmuch::pushed, unread]
        • Tomi Ollila—Re: [PATCH 6/6] lib: choose oldest message when breaking reference loops [inbox, unread]
          • David Bremner—Re: [PATCH 6/6] lib: choose oldest message when breaking reference loops [inbox, unread]
            • Tomi Ollila—Re: [PATCH 6/6] lib: choose oldest message when breaking reference loops [inbox, unread]
  • David Bremner—Re: reference loop fix and tests, v2 [inbox, unread]