Re: [PATCH] emacs: notmuch-tree: customizable strings for drawing trees

Subject:Re: [PATCH] emacs: notmuch-tree: customizable strings for drawing trees

Date:Mon, 30 Aug 2021 19:43:36 +0100

To:David Bremner ,notmuch@notmuchmail.org

Cc:

From:Jose Antonio Ortega Ruiz


On Mon, Aug 30 2021, David Bremner wrote:

> jao <jao@gnu.org> writes:
>
>> +(defcustom notmuch-tree-thread-symbols '(" " "─" "┬" "│" "├" "╰" "►")
>
> How hard would it be to use a plist or an alist, and allow the user to
> overide only the symbols they are interested in?

not hard at all... we just need to figure out good names (suggestions
welcome).  i think i'd prefer an alist, but it's not a strong preference
if you'd rather have a plist.

>> +      (push (elt notmuch-tree-thread-symbols 4) tree-status))
>
> As hinted above, I don't love the intriduction of magic indices,
> although I guess it might be tolerable if they are used only in one place.

yes, i agree.  i even had some code where i had variables for those
indices, but felt a bit overkill for things used in just one place.  but
using a plist/alist would give us what we need here.
_______________________________________________
notmuch mailing list -- notmuch@notmuchmail.org
To unsubscribe send an email to notmuch-leave@notmuchmail.org

Thread: