Re: [PATCH] contrib: pick: bugfix when trying to show a non-message

Subject: Re: [PATCH] contrib: pick: bugfix when trying to show a non-message

Date: Thu, 08 Nov 2012 22:57:37 -0400

To: Mark Walters, notmuch@notmuchmail.org

Cc:

From: David Bremner

Mark Walters <markwalters1009@gmail.com> writes:

> -  (concat "id:\"" (notmuch-pick-get-prop :id) "\""))
> +  (let ((id (notmuch-pick-get-prop :id)))
> +    (when id
> +      (concat "id:\"" id "\""))))

I don't know how other people feel, but I'd rather have an `if' in a
context where I care about the return value.

Thread: