Re: [PATCH] lib: have two definitions of NOTMUCH_DEPRECATED macro

Subject: Re: [PATCH] lib: have two definitions of NOTMUCH_DEPRECATED macro

Date: Tue, 08 Dec 2015 08:44:10 -0400

To: Tomi Ollila, notmuch@notmuchmail.org

Cc: tomi.ollila@iki.fi

From: David Bremner

Tomi Ollila <tomi.ollila@iki.fi> writes:

> Some compilers (older than gcc 4.5 and clang 2.9) do support
> __attribute__ ((deprecated)) but not
> __attribute__ ((deprecated("message"))).
>
> Check (clang) and know (gcc) which versions support which variants
> and make two definitions of define NOTMUCH_DEPRECATED macro;
> one with and and one without the ("message") part.
>
> __has_extension() replacement was modeled after __has_attribute()
> definition in compat/function-attributes.h. Thanks Justus.

Hi Tomi;

I keep coming back to review this patch, but I'm blocked by the fact
that clang++ is broken on Debian (and lots of other places, I guess) for
months.

        https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=797038

d

Thread: