Re: [PATCH 5/6] Modify our local copy of message-do-fcc

Subject: Re: [PATCH 5/6] Modify our local copy of message-do-fcc

Date: Sat, 03 Sep 2016 19:37:21 -0300

To: Mark Walters, notmuch@notmuchmail.org

Cc:

From: David Bremner


Mark Walters <markwalters1009@gmail.com> writes:

> Many thanks for the review.
>
> On Sat, 03 Sep 2016, David Bremner <david@tethera.net> wrote:
>> Mark Walters <markwalters1009@gmail.com> writes:
>>
>>> +	   (cons '("Newsgroups" . default)
>>> +		 rfc2047-header-encoding-alist)))
>>   this seems like more message-mode functionality we don't need? I guess
>>   it's harmless, but could omit one dynamically bound variable.
>
> I agree this might as well be removed.
>
>>> +	 (while list
>>> +	   (setq file (pop list))
>>> +	   (notmuch-fcc-handler file))
>>> +	 (kill-buffer (current-buffer)))))))
>>
>> Is it sensible for us to support a list of output destinations? It seems
>> like an odd corner case to me. I guess the amount of extra code is not
>> too high. In any case I suppose it could be a followup (as could my
>> comment above).
>
> We get a list here if someone has more than one fcc header. I don't know
> why they would want to, but gnus supported it so I kept it. I am happy
> either way here.

Hmm. OK. let's leave it as long as it doesn't cause any problems

d

Thread: