Re: [PATCH 0/9] argument parsing fixes and improvements

Subject: Re: [PATCH 0/9] argument parsing fixes and improvements

Date: Sun, 01 Oct 2017 08:11:09 -0300

To: Jani Nikula, Daniel Kahn Gillmor

Cc: Notmuch Mail

From: David Bremner


Jani Nikula <jani@nikula.org> writes:

> On Sat, 30 Sep 2017, Jani Nikula <jani@nikula.org> wrote:
>> Looking at the defaults from another angle, if we don't want the ability
>> to set --foo=default explicitly, I still think passing ints as booleans
>> to the argument parser and checking if a boolean is neither true nor
>> false is the wrong thing to do. I'd also like to convert to stdbool
>> more. But those should not be a reason to convert essentially boolean
>> arguments to keyword arguments. I think we need a way to have the
>> argument parser tell us if an argument was present or not.
>
> id:20170930213239.15392-1-jani@nikula.org would make it easier to add,
> say, a notmuch_bool_t *present field to notmuch_opt_desc_t that we could
> set whenever we see the option and we want to know the difference.

OK, I've queued that patch. Care to add `present` so we can unblock this
discussion?

d
_______________________________________________
notmuch mailing list
notmuch@notmuchmail.org
https://notmuchmail.org/mailman/listinfo/notmuch

Thread: