Re: [PATCH 01/38] lib: add _notmuch_string_map_set

Subject: Re: [PATCH 01/38] lib: add _notmuch_string_map_set

Date: Sun, 24 Jan 2021 08:06:56 -0400

To: Tomi Ollila, notmuch@notmuchmail.org

Cc:

From: David Bremner

Tomi Ollila <tomi.ollila@iki.fi> writes:

> On Sat, Jan 16 2021, David Bremner wrote:
>
>
> First, is this patch series safe to be applied and put into use ? :D

At least the backwards compatibility part is pretty well tested. I have
been running variations of it for a month or so.

>
> The style in string-map.c (and matches the .h above) would indicate the abobe should be:
>
> _notmuch_string_map_set (notmuch_string_map_t *map, 
>                          const char *key, 
>                          const char *val)
>

Sure. Although I think string-map.c is not completely consistent, that
is no reason not to match the header for new stuff.

d
_______________________________________________
notmuch mailing list -- notmuch@notmuchmail.org
To unsubscribe send an email to notmuch-leave@notmuchmail.org

• Previous message (by thread): Re: [PATCH 37/38] CLI: use configured hook directory

Thread:

• David Bremner—v4 merged config. [inbox, unread]
  • David Bremner—[PATCH 01/38] lib: add _notmuch_string_map_set [inbox, notmuch::obsolete, notmuch::patch, unread]
    • Tomi Ollila—Re: [PATCH 01/38] lib: add _notmuch_string_map_set [inbox, unread]
      • David Bremner—Re: [PATCH 01/38] lib: add _notmuch_string_map_set [inbox, unread]
  • David Bremner—[PATCH 02/38] lib: cache configuration information from database [inbox, notmuch::obsolete, notmuch::patch, unread]
  • David Bremner—[PATCH 03/38] lib: add stub for notmuch_database_open_with_config [inbox, notmuch::obsolete, notmuch::patch, unread]
  • David Bremner—[PATCH 04/38] lib/open: add support for config profiles and default locations [inbox, notmuch::obsolete, notmuch::patch, unread]
    • Tomi Ollila—Re: [PATCH 04/38] lib/open: add support for config profiles and default locations [inbox, unread]
  • David Bremner—[PATCH 05/38] CLI: generalize notmuch_config_mode_t [inbox, notmuch::obsolete, notmuch::patch, unread]
  • David Bremner—[PATCH 06/38] lib/config: add notmuch_config_key_{get,set} [inbox, notmuch::obsolete, notmuch::patch, unread]
  • David Bremner—[PATCH 07/38] lib/open: load default values for known configuration keys. [inbox, notmuch::obsolete, notmuch::patch, unread]
  • David Bremner—[PATCH 08/38] CLI: add (unused) database argument to subcommands. [inbox, notmuch::obsolete, notmuch::patch, unread]
  • David Bremner—[PATCH 09/38] util: add strsplit_len: simplified strtok with delimiter escaping [inbox, notmuch::obsolete, notmuch::patch, unread]
  • David Bremner—[PATCH 10/38] lib/config: add config values iterator [inbox, notmuch::obsolete, notmuch::patch, unread]
  • David Bremner—[PATCH 11/38] lib/config: make values iterators restartable [inbox, notmuch::obsolete, notmuch::patch, unread]
  • David Bremner—[PATCH 12/38] CLI/count: switch to new configuration framework [inbox, notmuch::obsolete, notmuch::patch, unread]
  • David Bremner—[PATCH 13/38] cli/dump: convert to new config framework [inbox, notmuch::obsolete, notmuch::patch, unread]
  • David Bremner—[PATCH 14/38] lib: add notmuch_config_get_bool [inbox, notmuch::obsolete, notmuch::patch, unread]
  • David Bremner—[PATCH 15/38] CLI/restore: convert to new config framework [inbox, notmuch::obsolete, notmuch::patch, unread]
  • David Bremner—[PATCH 16/38] CLI/insert: convert to new config framework. [inbox, notmuch::obsolete, notmuch::patch, unread]
  • David Bremner—[PATCH 17/38] cli/reindex: convert new config framework [inbox, notmuch::obsolete, notmuch::patch, unread]
  • David Bremner—[PATCH 18/38] CLI/reply: convert to new config framework [inbox, notmuch::obsolete, notmuch::patch, unread]
  • David Bremner—[PATCH 19/38] CLI/{search,address}: convert to new configuration framework [inbox, notmuch::obsolete, notmuch::patch, unread]
  • David Bremner—[PATCH 20/38] cli/config: add accessor for config file name [inbox, notmuch::obsolete, notmuch::patch, unread]
  • David Bremner—[PATCH 21/38] CLI/show: mostly switch show to new config framework [inbox, notmuch::obsolete, notmuch::patch, unread]
  • David Bremner—[PATCH 22/38] cli/tag: convert to new config framework. [inbox, notmuch::obsolete, notmuch::patch, unread]
  • David Bremner—[PATCH 23/38] lib/config: add _notmuch_config_cache [inbox, notmuch::obsolete, notmuch::patch, unread]
  • David Bremner—[PATCH 24/38] lib: split notmuch_database_compact [inbox, notmuch::obsolete, notmuch::patch, unread]
  • David Bremner—[PATCH 25/38] cli/compact: convert to new configuration framework [inbox, notmuch::obsolete, notmuch::patch, unread]
  • David Bremner—[PATCH 26/38] bindings/notmuch2: add missing crypto error status codes [inbox, notmuch::obsolete, notmuch::patch, unread]
  • David Bremner—[PATCH 27/38] lib/config: add NOTMUCH_CONFIG_NEW_IGNORE [inbox, notmuch::obsolete, notmuch::patch, unread]
  • David Bremner—[PATCH 28/38] lib/open: factor out first part of open [inbox, notmuch::obsolete, notmuch::patch, unread]
  • David Bremner—[PATCH 29/38] lib: add NOTMUCH_STATUS_NO_CONFIG [inbox, notmuch::obsolete, notmuch::patch, unread]
  • David Bremner—[PATCH 30/38] lib/database: move n_d_create* to open.cc [inbox, notmuch::obsolete, notmuch::patch, unread]
  • David Bremner—[PATCH 31/38] lib: add NOTMUCH_STATUS_DATABASE_EXISTS [inbox, notmuch::obsolete, notmuch::patch, unread]
  • David Bremner—[PATCH 32/38] lib: introduce notmuch_database_create_with_config [inbox, notmuch::obsolete, notmuch::patch, unread]
  • David Bremner—[PATCH 33/38] cli/new: refactor database upgrade code [inbox, notmuch::obsolete, notmuch::patch, unread]
  • David Bremner—[PATCH 34/38] cli/new: convert to new config framework [inbox, notmuch::obsolete, notmuch::patch, unread]
  • David Bremner—[PATCH 35/38] lib/config: add HOOK_DIR [inbox, notmuch::obsolete, notmuch::patch, unread]
  • David Bremner—[PATCH 36/38] lib/open: set HOOK_DIR on open [inbox, notmuch::obsolete, notmuch::patch, unread]
  • David Bremner—[PATCH 37/38] CLI: use configured hook directory [inbox, notmuch::obsolete, notmuch::patch, unread]
    • Tomi Ollila—Re: [PATCH 37/38] CLI: use configured hook directory [inbox, unread]
  • David Bremner—[PATCH 38/38] doc: describe new config framework [inbox, notmuch::obsolete, notmuch::patch, unread]