Re: [PATCH 01/38] lib: add _notmuch_string_map_set

Subject: Re: [PATCH 01/38] lib: add _notmuch_string_map_set

Date: Sun, 24 Jan 2021 08:06:56 -0400

To: Tomi Ollila,


From: David Bremner

Tomi Ollila <> writes:

> On Sat, Jan 16 2021, David Bremner wrote:
> First, is this patch series safe to be applied and put into use ? :D

At least the backwards compatibility part is pretty well tested. I have
been running variations of it for a month or so.

> The style in string-map.c (and matches the .h above) would indicate the abobe should be:
> _notmuch_string_map_set (notmuch_string_map_t *map, 
>                          const char *key, 
>                          const char *val)

Sure. Although I think string-map.c is not completely consistent, that
is no reason not to match the header for new stuff.

notmuch mailing list --
To unsubscribe send an email to