Re: [PATCH] test: aggregate-results updates

Subject: Re: [PATCH] test: aggregate-results updates

Date: Tue, 03 Aug 2021 22:46:13 -0300

To: Tomi Ollila,


From: David Bremner

Tomi Ollila <> writes:

> On Mon, Aug 02 2021, David Bremner wrote:
>> Tomi Ollila <> writes:
>>> -	mkdir -p "$test_results_dir"
>>> +	test -d "$test_results_dir" || mkdir "$test_results_dir"
>> Lately I've notice some complaints during parallel test running
>> 	mkdir: cannot create directory '/home/bremner/software/upstream/notmuch/test/test-results': File exists
>> It seems like this change might be the culprit. Can you explain why it
>> was needed?
> ah, parallel test non-atomicity is the problem; fix would be to restore -p to mkdir
> (so it does not fail when another program executed mkdir between that test
> check and mkdir execution)

Switched back to mkdir -p here, the occasional test failure is worse
than the potential slowdown.

notmuch mailing list --
To unsubscribe send an email to