Daniel Kahn Gillmor <dkg@debian.org> writes:

> Thanks, Michael--
>
> This LGTM.
>
> It is more narrowly-targeted at permitting this specific variation than
> Bremner's earlier version of the patch (and it doesn't have any tests
> marked BROKEN), which is nice.
>
> It might be marginally cleaner to swap out the LEFT_ANGLE RIGHT_ANGLE
> variables for a single replacement variable like so:
>
> if [ $NOTMUCH_GMIME_EMITS_ANGLE_BRACKETS == 1 ]; then
>    EXPECTED_EMAIL_ADDR='<test_suite@notmuchmail.org>'
> else
>    EXPECTED_EMAIL_ADDR='test_suite@notmuchmail.org'
> fi

In the end I applied this version to master. Thanks to you both.

d
_______________________________________________
notmuch mailing list -- notmuch@notmuchmail.org
To unsubscribe send an email to notmuch-leave@notmuchmail.org