Re: [PATCH 2/2] search --output=files: Output all filenames for each matching message

Subject: Re: [PATCH 2/2] search --output=files: Output all filenames for each matching message

Date: Tue, 28 Jun 2011 12:20:31 -0700

To: Mark Anderson, notmuch@notmuchmail.org

Cc:

From: Carl Worth


On Tue, 28 Jun 2011 12:12:52 -0700, Carl Worth <cworth@cworth.org> wrote:
> I think the only thing I would like to see in addition is an update to
> the documentation to make it explicit that --output=files will emit all
> filenames for a message that has more than one filename.

Actually, I went to go update the documentation itself, and I found that
it doesn't really need anything new here. The current text is:

	--output=files

	Output the filenames of all messages matching the search terms,
        either one per line (--format=text) or as a JSON array
        (--format=json).

And that's pretty clearly "the filenames of all messages".

The fact that we share a single "message object" when two files contain
the same message-id seems like an implementation detail that's not worth
bringing up here. (It would add more concepts to the documentation but
not actually change the meaning.)

So I've pushed the test and fix as-is now.

-Carl

-- 
carl.d.worth@intel.com
part-000.sig (application/pgp-signature)

Thread: