Re: [PATCH] new: Improved workaround for mistaken new directories

Subject: Re: [PATCH] new: Improved workaround for mistaken new directories

Date: Wed, 29 Jun 2011 16:13:05 -0700

To: Austin Clements, notmuch@notmuchmail.org

Cc: amdragon@mit.edu

From: Carl Worth


On Wed, 29 Jun 2011 19:00:01 -0400, Austin Clements <amdragon@MIT.EDU> wrote:
> We work around this by setting the new directory's database mtime to
> -1 before scanning anything in the new directory.  This also obviates
> the need for the workaround used in 8c39e8d6.

Thanks. This is pushed.

> +    /* XXX This is a temporary workaround.  If we don't update the
> +     * database mtime until after processing messages in this
...
> +     * A better solution would be for notmuch_database_get_directory
> +     * to indicate if it really created a new directory or not, either
> +     * by a new out-argument, or by recording this information and
> +     * providing an accessor.

A much better "XXX" comment! It tells the potential reader of the future
what to do to be able to remove the comment. Thanks so much.

-Carl

-- 
carl.d.worth@intel.com
part-000.sig (application/pgp-signature)

Thread: