Re: [PATCH 0/4 v4] lib: Maildir flags synchronization fixes

Subject: Re: [PATCH 0/4 v4] lib: Maildir flags synchronization fixes

Date: Mon, 05 Nov 2012 22:16:36 -0400

To: Daniel, Louis Rilling

Cc: notmuch@notmuchmail.org

From: David Bremner


Daniel <quite@hack.org> writes:

> On Mon, Nov 21, 2011 at 08:41:42PM -0400, David Bremner wrote:
>> I pushed the first two patches in this series; the second two need to be
>> updated for the new "broken test" framework, and reviewed.
>
> And old one... What came of this patch?
>
> I came across it, having been annoyed by the fact that notmuch broke my reading
> habits by marking messages (in the mutt sense) as seen, which I hadn't really
> seen yet in mutt. I tried out the patch; it applied and seems to work. What can
> I do to make it be applied? Other than giving it some attention. I must say
> that I have zero insight in the test framework, but if that's what's needed
> from me...

The patches need to be reviewed for correctness and style. Typically any
non-trivial patch (or series) needs two reviews. You can see examples in
the archives of how this works.  They are currently marked stale, which
is supposed to mean they no long apply. On the other hand, if they apply
for you, maybe that tagging is wrong (see http://notmuchmail.org/nmbug/
for more information about patch tagging).

By the way, it seems like commit b88030b might be relevant.

d

Thread: