Re: [PATCH] python: Fix database.add_message

Subject: Re: [PATCH] python: Fix database.add_message

Date: Mon, 11 Sep 2017 22:56:51 -0300

To: Dylan Baker,

Cc: Daniel Kahn Gillmor

From: David Bremner

Dylan Baker <> writes:

> b10ce6bc23002d48916b1b2f375480e7540e3164 introduced a new index_file
> method as a replacement for add_message. It helpfully made add_message
> an alias for index_file, unfortunately it got the signature wrong by
> explicitly passing self as an argument.
> cc: Daniel Kahn Gillmor <>

Thanks. We have another version that I was about to commit

The only difference is that Gaute (more or less by request) added a
deprecation warning.  I don't really know how warnings in python work,
does that sound sensible?

notmuch mailing list