Re: [PATCH] configure: disallow whitespace in paths, extend checks to $PWD

Subject: Re: [PATCH] configure: disallow whitespace in paths, extend checks to $PWD

Date: Wed, 11 Sep 2019 16:21:25 -0400

To: Tomi Ollila, notmuch@notmuchmail.org

Cc:

From: Daniel Kahn Gillmor


On Sun 2019-09-01 23:09:46 +0300, Tomi Ollila wrote:
> Whitespace in $NOTMUCH_SRCDIR (and $PWD) may work in builds,
> but definitely will not work in tests. It would be difficult
> to make tests support whitespace in test filename paths -- and
> fragile to maintain if done.
>
> So it is just easier and safer to disallow whitespace there.
>
> In case of out of tree build $NOTMUCH_SRCDIR differs from $PWD
> (current directory). Extend this whitespace, and also previously
> made unsafe characters check to $PWD too.

This is a sad constraint to have, but i understand it and i think Tomi's
patch is both a sensible guard, and a realistic acknowledgement of the
state of play today.  If someone wants to fix it (which would be great),
they can remove these checks when they fix it.

LGTM, please merge.

        --dkg
signature.asc (application/pgp-signature)
_______________________________________________
notmuch mailing list
notmuch@notmuchmail.org
https://notmuchmail.org/mailman/listinfo/notmuch

Thread: