Re: [notmuch] [PATCH v2] Add functions notmuch-show-get-(bcc, cc, date, from, subject, to).

Subject: Re: [notmuch] [PATCH v2] Add functions notmuch-show-get-(bcc, cc, date, from, subject, to).

Date: Sat, 20 Feb 2010 12:19:18 -0800

To: david@tethera.net, notmuch@notmuchmail.org

Cc: David Bremner

From: Carl Worth


On Thu, 11 Feb 2010 22:44:10 -0400, david@tethera.net wrote:
> Return the corresponding header field for the current message as a
> string.  These are thin wrappers around notmuch-show-get-header, which
> means they each cause a full parse of the RFC822 header. The main idea
> is to fix an api.

OK. You at least acknowledge the only misgiving I had about this
patch. (And frankly, my own emacs lisp code probably has much worse
performance bugs.) So I'm not going to worry about that for now.

> Sorry, resending with fixed commit message.

Much appreciated.

> +(defun notmuch-show-get-bcc ()
> +  "Return To address of current message"
> +  (notmuch-show-get-header-field 'bcc))
> +
> +(defun notmuch-show-get-cc ()
> +  "Return To address of current message"
> +  (notmuch-show-get-header-field 'cc))
> +
> +(defun notmuch-show-get-date ()
> +  "Return To address of current message"
> +  (notmuch-show-get-header-field 'date))

I fixed the obviously copied documentation strings above, deleted the
trailing whitespace, and applied this patch.

Thanks!

-Carl
part-000.sig (application/pgp-signature)

Thread: