Re: [PATCH] Add missing call to g_type_init()

Subject: Re: [PATCH] Add missing call to g_type_init()

Date: Mon, 25 Jul 2011 13:53:10 -0700

To: Aaron Ecay, notmuch@notmuchmail.org

Cc:

From: Jameson Graef Rollins


On Mon, 25 Jul 2011 16:33:09 -0400, Aaron Ecay <aaronecay@gmail.com> wrote:
> Signed-off-by: Aaron Ecay <aaronecay@gmail.com>

Hey, Aaron.  Thanks for submitting this patch.  However, you will need
to provide a more detailed log message in order for it to be pulled by
Carl.  The commit message should explain what exactly the problem is,
and how this fixes it.  You also don't need to add the "Signed-off-by"
for your own patches.

I also forgot to mention that if there is a way to test against the
issue that is raised here, then you should probably provide a patch to
the test suite as well.  Some bugs are just bugs, though, and there's
not really a reasonable way to test for them.  That may be the case
here.

jamie.
part-000.sig (application/pgp-signature)

Thread: