Re: [PATCH] emacs: initialize ido mode in notmuch-mua.el

Subject: Re: [PATCH] emacs: initialize ido mode in notmuch-mua.el

Date: Sat, 25 Jan 2014 14:34:22 -0400

To: Mark Walters, notmuch@notmuchmail.org

Cc:

From: David Bremner


Mark Walters <markwalters1009@gmail.com> writes:

> ido-completing-read is used in notmuch-mua.el without any
> initialization.  This should work but a bug (emacs bug #3247) in some
> emacs 23 versions (including 23.2.1 from Debian stable) causes emacs
> to get stuck in the mini-buffer. This tests to see if ido-mode has
> been initialized and if not calls it. This avoids the bug for these
> older versions of emacs.
>
> This is the only place that ido-completing-read is used so an alternative 
> would be to replace ido-completing-read by completing-read but cworth 
> expressed a preference for the ido version in 
> id:"87wrhfvk6a.fsf@yoom.home.cworth.

This patch was tagged wip, but then there was no progress ;).  It still
applies cleanly, and doesn't seem to do any harm in emacs 23.4 nor
emacs24.3. I don't have 23.2 at hand but I guess Tomi or Mark can
confirm it actually fixes the bug there.

I propose we either apply the patch or ::wontfix the bug.

cheers,

d

Thread: