Re: [PATCH] test: add configurable port to smtp-dummy

Subject: Re: [PATCH] test: add configurable port to smtp-dummy

Date: Mon, 06 May 2019 16:55:17 -0400

To: Tomi Ollila, David Bremner, Rollins, Jameson, Notmuch Mail


From: Daniel Kahn Gillmor

On Mon 2019-05-06 22:39:26 +0300, Tomi Ollila wrote:
> we run smtp-dummy as:
>    smtp_dummy_pid=
>    eval `$TEST_DIRECTORY/smtp-dummy --background sent_message`
> if process binds using port `0` system fill find available port for it...
> ... which smtp-dummy could return in a variable to be evaluated ...
> ... and that could replace all this what has been done here ...

i agree with Tomi that something like this (smtp-dummy asks for an
available port and reports it), is the ideal solution, in that it means
that two copies of the notmuch testsuite itself could even run
independently and avoid contending for system resources.

but i think Bremner's manually-set port is a completely reasonable first
step, and we can adopt the proposed optimization later.  LGTM.

signature.asc (application/pgp-signature)
notmuch mailing list